Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip checking issuer when creating Provider. #122

Closed
wants to merge 1 commit into from
Closed

Skip checking issuer when creating Provider. #122

wants to merge 1 commit into from

Conversation

tamalsaha
Copy link

Fixes #121

@tamalsaha
Copy link
Author

@ericchiang Here is an example using Azure AD v2.0 https://github.com/appscode/gologin/blob/master/azure/login.go#L20

@ericchiang
Copy link
Collaborator

Per conversation in #121 I don't think we want to provide the ability to skip the issuer comparison. For example, in #121 this check was actually a good indication that the wrong issuer ID was being provided.

Okay for me to close?

@tamalsaha
Copy link
Author

@ericchiang I think using 9188040d-6c67-4c5b-b112-36a304b66dad instead of common results in proper issuer check. Closing this issue.

@tamalsaha tamalsaha closed this Jan 9, 2017
@ericchiang ericchiang mentioned this pull request Mar 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tamalsaha @ericchiang