Verify distributed claim endpoints #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericchiang
reviewed
Jun 4, 2018
verify_test.go
Outdated
| @@ -358,10 +452,45 @@ type verificationTest struct { | |||
| // testing invalid signatures. | |||
| verificationKey *signingKey | |||
|
|
|||
| config Config | |||
| config Config | |||
|
|
|||
There was a problem hiding this comment.
please remove this whitespace
verify_test.go
Outdated
| { | ||
| test: resolverTest{ | ||
| name: "noAccessToken", | ||
| payload: `{"iss":"","aud":"client1","email":"janedoe@email.com"}`, |
There was a problem hiding this comment.
include an issuer in these tests
verify_test.go
Outdated
| @@ -342,6 +345,97 @@ func TestDistributedClaims(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestDistClaimResolver(t *testing.T) { | |||
| tests := []struct { | |||
There was a problem hiding this comment.
This should just be
tests := []resolverTest{
// ...
}
We had the test.test in the other ones as a hack :)
verify_test.go
Outdated
|
|
||
| t.Run(test.test.name, func(t *testing.T) { | ||
|
|
||
| endpoint, err := test.test.testEndpoint(t) |
There was a problem hiding this comment.
this doesn't return an endpoint? does it? Need to rename it as "claims"
Also please remove the whitespace in the two lines above.
verify.go
Outdated
| @@ -118,6 +120,54 @@ func contains(sli []string, ele string) bool { | |||
| return false | |||
| } | |||
|
|
|||
| // Returns the Claims from the distributed JWT token | |||
| func resolveDistributedClaim(ctx context.Context, verifier *IDTokenVerifier, src claimSource) ([]byte, error) { | |||
|
|
|||
There was a problem hiding this comment.
no whitespace to start an indented block.
verify.go
Outdated
|
|
||
| req, err := http.NewRequest("GET", src.Endpoint, nil) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("oidc: malformed request: %v", err) |
There was a problem hiding this comment.
nit: this function isn't exported, so something else in the package going to prefix these errors with oidc:, we can remove this here.
| return token.claims, nil | ||
| } | ||
|
|
||
| func parseClaim(raw []byte, name string, v interface{}) error { |
There was a problem hiding this comment.
add a test for this method?
ericchiang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #171