Write generated Rust code to the source tree; apply fixups #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare to keep generated Rust code in Git. Regenerate it only when built with `cargo build --features regenerate`. Add anyhow as an unconditional build dependency because it makes the top-level error handling in build.rs easier. Requires Git version of Schemafy.
start_mi_b => start_mib size_mi_b => size_mib tpm_2 => tpm2 Fixes #2.
jlebon
approved these changes
Aug 3, 2021
Schemafy generates both a context-specific DirectoryUser/DirectoryGroup/etc. and a NodeUser/NodeGroup it doesn't use. Switch all references to the latter. Works around Marwes/schemafy#50.
They're now unused. Works around Marwes/schemafy#50.
jlebon
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store generated Rust code in Git, and regenerate it only when built with
cargo build --features regenerate. Then apply fixups:ItemandGroupin node user and group structs (works around Don't accumulate types of previous fields in type names Marwes/schemafy#49)DirectoryUser/DirectoryGroup/etc. with genericNodeUser/NodeGroupstructs and delete the context-specific ones (works around Inline object definitions referenced fromallOfare replicated once per reference Marwes/schemafy#50)Requires Git version of Schemafy.