This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
30ignition: GPT setup: wait for 'boot' labelled partition #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
reviewed
Jun 9, 2020
| # Make sure that we wait for the disk with the partition labeled 'boot' to come | ||
| # up. This is the only unit where it is safe to wait on a specific disk label. | ||
| # Units that requires specific partitions to be available should order | ||
| # themselves after ignition-diskful.target. |
There was a problem hiding this comment.
Did you mean ignition-disks.service?
There was a problem hiding this comment.
As far as I understand, you want to order after ignition-diskful.target to work on 1rst boot available partitions and after ignition-disks.service for ignition provisioned partitions. Maybe I should clarify the comment.
There was a problem hiding this comment.
I'd say it like anything that is operating on "persistent bootable disk" needs -diskful.target, as does this. We probably don't need to describe that in a comment here, the idea should be covered in the unit docs.
What I would say in this comment is two things:
- First, we don't have any plans to support re-provisioning/re-writing the
/bootpartition. So the disk holding it must be the root. - We can't use
rootbecause RHCOS's pre-setup LUKS container doesn't allow it
This all said...I am increasingly feeling we should make this logic part of ignition-disks.service along with coreos/fedora-coreos-config#354 or so.
cgwalters
approved these changes
Jun 9, 2020
travier
added a commit
to travier/fedora-coreos-config
that referenced
this pull request
Jun 9, 2020
The GPT setup unit was simplified to reflect the fact that it will only be called once for the disk with the partition labeled 'boot'. This keeps the old unit name for now for compatibility. This will be safe to remove once the dracut-ignition changes from [1] are available in the latest ignition RPM. [1] coreos/ignition-dracut#191
travier
added a commit
to travier/fedora-coreos-config
that referenced
this pull request
Jun 9, 2020
The GPT setup unit is simplified to reflect the fact that this unit will only be called once for the disk with the partition labeled 'boot'. This keeps the old unit name for now for compatibility. This will be safe to remove once the dracut-ignition changes from [1] are available in the latest ignition RPM. [1] coreos/ignition-dracut#191
This unit must the first to run when the disk holding the root partition becomes available. To avoid relying on the name of the root partition which is different between RHCOS LUKS setup and current FCOS setup, we wait for the partition labeled 'boot' to become available. This is reliable as we don't have any plan to support re-provisioning/re-writing the /boot partition, This is the only unit where it is safe to wait only on a specific disk label as this will call udevadm settle after the GPT setup. Units that requires the boot and root partitions to be available should order themselves after this unit.
|
Updated the comments to add more info. Working on a graph to explain more clearly why this is required and what the boot order will look like in the end. |
cgwalters
pushed a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Jun 11, 2020
The GPT setup unit is simplified to reflect the fact that this unit will only be called once for the disk with the partition labeled 'boot'. This keeps the old unit name for now for compatibility. This will be safe to remove once the dracut-ignition changes from [1] are available in the latest ignition RPM. [1] coreos/ignition-dracut#191
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that we wait for the disk with the partition labeled 'boot' to
come up. This is the only unit where it is safe to wait on a specific
disk label. Units that requires specific partitions to be available
should order themselves after ignition-diskful.target.
We used to wait for the partition labeled 'root' but this name will
change with LUKS support.