workflows: build and push ignition-validate container from GH Actions
#1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before landing this:
|
Reduce overhead by pulling in fewer deps.
Quay builds are amd64-only and haven't been especially reliable. Use GitHub Actions to build both amd64 and arm64 containers for the main branch and for tags, and push them to Quay. Continue building but not pushing containers on PR. Requires the QUAY_AUTH repo secret to be set to a Docker credential. Ideally we would cross-build the arm64 container by having the Dockerfile specify FROM --platform=$BUILDPLATFORM for the builder container and set GOARCH=$TARGETARCH. However, Buildah < 1.24.1 doesn't support --platform in FROM. Build in emulation for now, and skip arm64 in PRs to speed up CI. Fixes #1321.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quay builds are amd64-only and haven't been especially reliable. Use GitHub Actions to build both amd64 and arm64 containers for the main branch and for tags, and push them to Quay. Continue building but not pushing containers on PR. Requires the
QUAY_AUTHrepo secret to be set to a Docker credential.Ideally we would cross-build the arm64 container by having the Dockerfile specify
FROM --platform=$BUILDPLATFORMfor the builder container and setGOARCH=$TARGETARCH. However, Buildah < 1.24.1 doesn't support--platformin FROM. Build in emulation for now, and skip arm64 in PRs to speed up CI.Fixes #1321.