Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/vultr: Add Vultr provider #918

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

dghubble
Copy link
Member

@dghubble dghubble commented Jan 28, 2020

Background:

Hi! 馃憢 I've been using Fedora CoreOS on Vultr for some time. Using the installer ISO crashing to an emergency shell to supply a shim Ignition config that points to Vultr metadata server's user-data to create an image that will boot with Ignition on Vultr. Recently the Fedora CoreOS installer ISO seems to have been removed, so I'd like to add proper support.

@coreosbot
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Contributor

@arithx arithx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/providers/vultr/vultr.go Outdated Show resolved Hide resolved
@arithx
Copy link
Contributor

arithx commented Jan 28, 2020

ok to test

internal/providers/vultr/vultr.go Outdated Show resolved Hide resolved
internal/providers/vultr/vultr.go Outdated Show resolved Hide resolved
* Add Vultr as a provider, user-data can be an Ignition config
* Metadata endpoint is http://169.254.169.254/user-data/user-data
@lucab
Copy link
Contributor

lucab commented Jan 28, 2020

@dghubble thanks for the PR!
There a few other things that likely need some more glueing work (documenting the platform ID, teaching coreos-assembler how to build the image, plumbing the artifacts through the pipeline, teaching afterburn about additional metadata/ssh-keys), not sure how much of that you want to do yourself.
Perhaps we should open an umbrella ticket at https://github.com/coreos/fedora-coreos-tracker and coordinate that way?

@jlebon
Copy link
Member

jlebon commented Jan 28, 2020

Yeah, we need to discuss first whether we want to support this cloud. How "vanilla" is it? If it's just a matter of restamping a disk image with its platform ID, then that's easier to justify. But if there are other platform requirements that could cause a higher maintenance burden, that changes things. Though from what you're saying, it's been working fine as is apart from the user-data bits?

Anyway, agreed re. filing a tracker ticket to discuss this first!

@dghubble
Copy link
Member Author

Thanks for the comments, I've filed coreos/fedora-coreos-tracker#355 to discuss

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jlebon jlebon merged commit f430a6c into coreos:master Jan 30, 2020
jlebon pushed a commit to coreos/coreos-assembler that referenced this pull request Jan 31, 2020
* Build a raw image with the Ignition provider set to vultr
to correspond with coreos/ignition#918
* coreos/fedora-coreos-tracker#355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants