-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
providers/vultr: Add Vultr provider #918
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ok to test |
51bd60b
to
801470a
Compare
* Add Vultr as a provider, user-data can be an Ignition config * Metadata endpoint is http://169.254.169.254/user-data/user-data
801470a
to
b962250
Compare
@dghubble thanks for the PR! |
Yeah, we need to discuss first whether we want to support this cloud. How "vanilla" is it? If it's just a matter of restamping a disk image with its platform ID, then that's easier to justify. But if there are other platform requirements that could cause a higher maintenance burden, that changes things. Though from what you're saying, it's been working fine as is apart from the user-data bits? Anyway, agreed re. filing a tracker ticket to discuss this first! |
Thanks for the comments, I've filed coreos/fedora-coreos-tracker#355 to discuss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Build a raw image with the Ignition provider set to vultr to correspond with coreos/ignition#918 * coreos/fedora-coreos-tracker#355
Background:
Hi! 馃憢 I've been using Fedora CoreOS on Vultr for some time. Using the installer ISO crashing to an emergency shell to supply a shim Ignition config that points to Vultr metadata server's user-data to create an image that will boot with Ignition on Vultr. Recently the Fedora CoreOS installer ISO seems to have been removed, so I'd like to add proper support.