src/cmd-buildextend-vultr: prepare a Vultr raw image #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
dghubble
changed the title
cgwalters
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
Seems sane to me as a start. Let's at least link to coreos/fedora-coreos-tracker#355 in the commit message?
* Build a raw image with the Ignition provider set to vultr to correspond with coreos/ignition#918 * coreos/fedora-coreos-tracker#355
|
LGTM, this follows the new model :) |
jlebon
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, I was able to build a new coreos-assembler and use it to build a
fedora-coreos-31.20200128.dev.0-vultr.x86_64.rawthat claims to have thevultrplatform id set. No change to Ignition yet, so its not of practical use yet, but its something.