kola/tests: check for AWS friendly device name #876
Conversation
|
Perhaps check if any nvme devices exist first and skip if they don't? Otherwise this test gives false positives on instance types without nvme. |
|
@ajeddeloh the idea is that every instance (booted with default parameter) has a friendly disk name for its main volume, regardless of its instance type and nvme/non-nvme. This checks that such invariant holds everywhere, as we just fixed the broken corner-case of nvme. |
kola/tests/misc/aws.go
Outdated
| friendlyName := "/dev/xvda" | ||
| out := c.MustSSH(c.Machines()[0], fmt.Sprintf("stat %s", friendlyName)) | ||
|
|
||
| if strings.Contains(string(out), "No such file or directory") { |
There was a problem hiding this comment.
Is this necesary since stat should return non-zero on ENOTFOUND
There was a problem hiding this comment.
Oh, does it? I think I overlooked MustSSH return value, that would be cool. I'll re-check tomorrow.
There was a problem hiding this comment.
Indeed the string check here was duplicating the internal error checking. I just dropped that.
lucab
force-pushed
the
ups/kola-tests-misc-aws
branch
from
6d14e00
to
2e00b49
Compare
Test covering friendly names on AWS, recently fixed on some specific instance types at coreos/bugs#2399. This invariant should not be instance-specific though.