-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support make check tests too #75
Comments
Would it make sense to split things such that the installed tests exercise the CLI and the "make check" tests ring out the libostree API to a reasonable extent? Also, Philip Withnall's uhttpmock might be useful for simulating fetches. We used that with E-D-S to some success. https://www.openhub.net/p/uhttpmock |
A starting point in ostreedev/ostree#28 |
WRT splitting installed/make check - I would prefer if installedtests was a superset of makecheck. For tests which don't access data, this is quite easy. It is harder if you need to read data, but newer GLib testing has some bits for that. I'm starting to use that in #76 . |
I was probably too agressive with OSTree in relying on only on https://wiki.gnome.org/GnomeGoals/InstalledTests . Let's take a look at a project which is doing both
make check
and installed, and handle both. glib/json-glib? Cockpit also has invested a lot in tests, should look there too.The text was updated successfully, but these errors were encountered: