Port to glib-tap.mk #76
Conversation
|
Ack - reviewing, may take me a little while. |
|
This testing framework is new to me, so not much insight here from a review standpoint. For the pasted files I really only examined the differences from GLib's copy. For those pasted-in files, I suggest for the record noting their origin at least in the commit message. I've used as-compiler-flag.m4 myself before. I assume most of the glib-tap stuff originated in GLib? tap-driver.sh looks like it comes from the automake project? The JSON unit tests look fine to me. |
Not actually used yet; we'll need to modify these in subsequent commits, but this is the starting point. Future commits will therefore have a useful diff. Even if admittedly it's unlikely they'll re-unify in the near future.
These files were taken from json-glib, around the era of this commit: https://git.gnome.org/browse/json-glib/tree/build/autotools?id=2779d537492f1902d71cf648631238110b62b311 Unfortunately, this involved hacking it up a bit: - I couldn't easily use `nobase` for the data, so I deleted that. Test data goes in the installed-tests dir. - Delete duplicated predeclared variables; we're using nonrecursive make. - Ensure we run each test in its own tmpdir
Adding some basic coverage of the json parsing.
|
OK, I split out "copy the files unchanged" as a separate commit and more clearly recorded their provenance from json-glib. Also dropped |
|
Nice, I like that -- clean import in one commit and changes in the next. 👍 |
|
Merged, thanks! |
Unfortunately, this involved hacking it up a bit:
nobasefor the data, so I deleted that.Test data goes in the installed-tests dir.
make.