Add a public shared library, with "rpm -qa" for commit functionality #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Continuation of #123 |
This will help build release engineering and other types of tools; for example, rather than parsing the output of `db diff`, one should be able to call an API. Initially, this adds the generic infrastructure for a public shared library, with a new function call to do the equivalent of `rpm -qa` on a particular OSTree commit. Closes: coreos#117
|
Rebased on master, added a commit to add gtk-doc. |
|
Looks good to me and builds successfully here. One very minor quibble -- and this might just be personal preference -- is for |
cgwalters
added a commit
that referenced
this pull request
Apr 13, 2015
This will help build release engineering and other types of tools; for example, rather than parsing the output of `db diff`, one should be able to call an API. Initially, this adds the generic infrastructure for a public shared library, with a new function call to do the equivalent of `rpm -qa` on a particular OSTree commit. Closes: #117 Closes: #124
|
I tend to write all APIs like it came out of a code generator by default, I admit. But there's certainly nothing wrong with the "return directly" for structures. I changed the code and merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help build release engineering and other types of tools;
for example, rather than parsing the output of
db diff, oneshould be able to call an API.
Initially, this adds the generic infrastructure for a public shared
library, with a new function call to do the equivalent of
rpm -qaona particular OSTree commit.
Closes: #117