Add more client Rust bindings, port apply-live builtin #2629
Conversation
|
Skipping CI for Draft Pull Request. |
|
OK right and I forgot I'd already experimented with better GVariant bindings; there are some in gtk-rs git from gtk-rs/glib#651 but not in a release yet, and even then the version of gtk-rs is exposed by higher level bindings like ostree-rs that we need to also update, etc. |
cgwalters
changed the title
cgwalters
changed the title
|
OK pushed another commit here that fully pushes over the But this shows how we can start writing new CLI entrypoints in Rust to start (with awesome stuff like structopt etc.) and hopefully slowly port over more of the existing C/C++ entrypoints. |
cgwalters
force-pushed
the
client-rs
branch
2 times, most recently
from
34dfb3f
to
c876588
Compare
rust/src/client.rs
Outdated
| )?; | ||
| // Today the daemon mode basically requires running inside a booted | ||
| // deployment. Technically, in the future our architecture could | ||
| // support |
rust/src/builtins/apply_live.rs
Outdated
| let params = unsafe { | ||
| let args = args.to_glib_none().0; | ||
| let r = glib_sys::g_variant_new_tuple(&args as *const *mut _, 1); | ||
| glib_sys::g_variant_ref_sink(r); | ||
| from_glib_full(r) | ||
| }; |
There was a problem hiding this comment.
Might be worth a wrapper function for this bit.
There was a problem hiding this comment.
OK yeah, definitely. I added a variant_utils.rs.
cgwalters
force-pushed
the
client-rs
branch
2 times, most recently
from
276dcf1
to
3234b74
Compare
Originally it was dbus helpers, but it grew into "shared code for client", so let's name the file better.
Prep for exposing just this functionality via cxxrs so we can more easily write CLI entrypoints in Rust.
This stubs out sufficient infrastructure for us to register as a client and call the Moo API. A glaring problem here is the lack of extensive `glib::Variant` bindings; that's covered in the next gtk-rs release. My real goal was to try porting the `rpmostree-builtin-apply-live.cxx` code entirely to Rust, but there's more to do to expose the transaction helper APIs we have.
|
Rebased 🏄 |
This adds sufficient infrastructure to fully port the `rpmostree-builtin-applylive.cxx` client code to Rust. We just keep a stub entrypoint for now until we port the rest of `rpmostree-builtin-ex.cxx`, at which point a lot of C++ files go away. The "finish" bits move from the daemon-oriented `live.rs` into a new `rust/src/builtins` directory. I'd like to try to more cleanly split up the Rust sources along core(shared)/client/daemon directories in the future.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
app: Rename dbus-helpers to clientlib
Originally it was dbus helpers, but it grew into "shared code for client",
so let's name the file better.
app: Factor out a helper function to register as a client
Prep for exposing just this functionality via cxxrs so we
can more easily write CLI entrypoints in Rust.
Add basic Rust CLI bindings for DBus
This stubs out sufficient infrastructure for us to register
as a client and call the Moo API.
A glaring problem here is the lack of extensive
glib::Variantbindings; that's covered in the next gtk-rs release.
My real goal was to try porting the
rpmostree-builtin-apply-live.cxxcode entirely to Rust, but there's more to do to expose the
transaction helper APIs we have.
Add more client Rust bindings, port apply-live builtin
This adds sufficient infrastructure to fully port the
rpmostree-builtin-applylive.cxxclient code to Rust.We just keep a stub entrypoint for now until we port
the rest of
rpmostree-builtin-ex.cxx, at which pointa lot of C++ files go away.
The "finish" bits move from the daemon-oriented
live.rsinto a new
rust/src/builtinsdirectory. I'd liketo try to more cleanly split up the Rust sources along
core(shared)/client/daemon directories in the future.