Add container Variant API #651

zeenix · 2020-06-05T20:52:10Z

This PR will add container Variant API. It already adds basic array support.

zeenix · 2020-06-05T20:54:12Z

@sdroege Marked as WIP as I'm sure I'll be adding more API soon. But have a look already if you like the direction or not.

src/variant.rs

sdroege · 2020-06-05T21:16:25Z

Goes into the right direction IMHO, thanks :)

sdroege · 2020-06-06T15:07:40Z

So only thing missing here is the FromVariant / ToVariant impls for Vec/slice/tuples/hashmap or also something else?

zeenix · 2020-06-06T17:03:24Z

So only thing missing here is the FromVariant / ToVariant impls for Vec/slice/tuples/hashmap or also something else?

Yeah, I'll try to add those but for my own needs, the only thing that I know is missing is g_variant_new_dict_entry wrapper.

sdroege · 2020-06-06T18:36:06Z

Yeah, I'll try to add those

Well without these, the new trait impls are not really useful yet :)

zeenix · 2020-06-06T18:43:51Z

Well without these, the new trait impls are not really useful yet :)

They are, you can create the Variant from bytes or manually create it (like the array example in my patches). But yeah, w/o those conversions, the API will still be very incomplete.

sdroege · 2020-07-08T06:51:05Z

Any updates here?

zeenix · 2020-07-08T10:21:04Z

Any updates here?

no. :( If you want to merge what we already have here, let's unmark it as WIP and merge. I can always add additional PRs.

sdroege · 2020-07-08T10:22:11Z

Without the remaining trait impls it's not really useful yet, so let's just wait :) Too late for this release now anyway, it happened already.

zeenix · 2020-07-08T10:44:20Z

Without the remaining trait impls it's not really useful yet, so let's just wait :) Too late for this release now anyway, it happened already.

Sure. :)

sdroege · 2020-08-18T08:24:40Z

Any updates here?

zeenix · 2020-08-18T11:33:55Z

Any updates here?

No, for me it's not an isolated effort but rather something I've been doing as part of the gvariant addition in zvariant (so it gets some real testing) but there has been more important zbus bugs/issues that I've been looking into, in my limited sparetime before I could continue finishing this work.

sdroege

Looks like good progress :)

src/variant.rs

sdroege · 2020-09-03T13:45:13Z

Now just needs to merge cleanly :) Can you remove those "Revert Revert" commits and the gir update commit?

zeenix · 2020-09-03T14:45:12Z

Now just needs to merge cleanly :) Can you remove those "Revert Revert" commits and the gir update commit?

Rebased. Although I failed to test the results because:

$ cargo test
error: failed to select a version for `glib-sys`.
    ... required by package `glib v0.10.0 (/home/zeenix/checkout/gnome/glib-rs)`
versions that meet the requirements `=0.9.1` are: 0.9.1

the package `glib` depends on `glib-sys`, with features: `v2_64` but `glib-sys` does not have these features.


failed to select a version for `glib-sys` which could resolve this conflict

Cargo clean didn't help, neither did removal of selected folders under ~.cargo.

zeenix · 2020-09-03T14:47:04Z

Rebased. Although I failed to test the results because:

Nm, needed cargo update. All tests pass still.

sdroege · 2020-09-03T16:32:39Z

Needs a run of cargo fmt, seems otherwise the CI is happy :)

This will allow us to create Variant instances from encoded data for container types. The API to query and manipulate a container carying Variant will follow in another patch.

So that `new_from_bytes` can be used with Variant type.

This is useful when combined with the container variant functions and trait implementations from gtk-rs#651. Implementing `ToVariant` would be useful as well, but isn't currently possible: gtk-rs#678

This is useful when combined with the container variant functions and trait implementations from gtk-rs#651. BREAKING CHANGE: This remove `impl<T: ToVariant> From<T> for Variant`, which made it impossible to implement `ToVariant` since it conflicts with the standard library `impl<T> From<T> for T`: gtk-rs#678

This is useful when combined with the container variant functions and trait implementations from gtk-rs/glib#651. BREAKING CHANGE: This remove `impl<T: ToVariant> From<T> for Variant`, which made it impossible to implement `ToVariant` since it conflicts with the standard library `impl<T> From<T> for T`: gtk-rs/glib#678

zeenix mentioned this pull request Jun 5, 2020

Allow container types in Variant #650

Closed

sdroege reviewed Jun 5, 2020

View reviewed changes

src/variant.rs Outdated Show resolved Hide resolved

sdroege reviewed Jun 5, 2020

View reviewed changes

src/variant.rs Outdated Show resolved Hide resolved

sdroege reviewed Jun 5, 2020

View reviewed changes

src/variant.rs Outdated Show resolved Hide resolved

sdroege reviewed Jun 5, 2020

View reviewed changes

src/variant.rs Outdated Show resolved Hide resolved

sdroege reviewed Jun 5, 2020

View reviewed changes

src/variant.rs Show resolved Hide resolved

zeenix force-pushed the complete-variant branch from cc27e58 to 66f21ae Compare June 6, 2020 11:40

zeenix force-pushed the complete-variant branch from 66f21ae to 4536a11 Compare June 15, 2020 20:32

sdroege mentioned this pull request Jul 24, 2020

Add GVariant bindings for non-basic types, nested types: arrays, tuples, dicts, ... #113

Closed

zeenix force-pushed the complete-variant branch from b9d6948 to ad1e6e5 Compare September 1, 2020 20:31

sdroege reviewed Sep 2, 2020

View reviewed changes

zeenix force-pushed the complete-variant branch from ad1e6e5 to bf5c327 Compare September 2, 2020 18:19

zeenix changed the title ~~WIP: Add container Variant API~~ Add container Variant API Sep 2, 2020

sdroege reviewed Sep 3, 2020

View reviewed changes

src/variant.rs Show resolved Hide resolved

sdroege reviewed Sep 3, 2020

View reviewed changes

src/variant.rs Outdated Show resolved Hide resolved

sdroege reviewed Sep 3, 2020

View reviewed changes

src/variant.rs Show resolved Hide resolved

sdroege reviewed Sep 3, 2020

View reviewed changes

src/variant.rs Show resolved Hide resolved

sdroege reviewed Sep 3, 2020

View reviewed changes

src/variant.rs Show resolved Hide resolved

zeenix force-pushed the complete-variant branch from 96ce784 to 5dc35f6 Compare September 3, 2020 13:40

zeenix force-pushed the complete-variant branch from 5dc35f6 to 2c9df92 Compare September 3, 2020 14:43

zeenix added 11 commits September 3, 2020 19:09

Implement StaticVariantType for common Rust container types

8a47566

This will allow us to create Variant instances from encoded data for container types. The API to query and manipulate a container carying Variant will follow in another patch.

Bindings for Variant boxing/unboxing API

2d616d6

impl StaticVariantType for Variant

86c7395

So that `new_from_bytes` can be used with Variant type.

Basic API for container-type Variant

300ef35

Allow creating Array type Variant

df1b340

Export FromVariant in public API

733f152

Add conversion between Vec<T> and Variant

fe257e4

API for creating dictionary entries

3ee2313

Add conversion between Variant and HashMap

1230019

API to create tuple Variant & convert it to/from tuples

1deff1a

Variant support for Option (Maybe type of GVariant)

4a9a203

zeenix force-pushed the complete-variant branch from 2c9df92 to 4a9a203 Compare September 3, 2020 17:18

sdroege merged commit 4516a75 into gtk-rs:master Sep 3, 2020

zeenix deleted the complete-variant branch September 3, 2020 20:13

ids1024 mentioned this pull request Sep 3, 2020

Implement ToVariant and FromVariant for Variant (not currently possible) #678

Closed

ids1024 mentioned this pull request Sep 3, 2020

Implement FromVariant for Variant #679

Merged

cgwalters mentioned this pull request Mar 2, 2021

Add more client Rust bindings, port apply-live builtin coreos/rpm-ostree#2629

Merged

zeenix mentioned this pull request May 14, 2021

Bindings for GVariantBuilder gtk-rs/gtk-rs-core#26

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add container Variant API #651

Add container Variant API #651

zeenix commented Jun 5, 2020

zeenix commented Jun 5, 2020

sdroege commented Jun 5, 2020

sdroege commented Jun 6, 2020

zeenix commented Jun 6, 2020

sdroege commented Jun 6, 2020

zeenix commented Jun 6, 2020

sdroege commented Jul 8, 2020

zeenix commented Jul 8, 2020

sdroege commented Jul 8, 2020

zeenix commented Jul 8, 2020

sdroege commented Aug 18, 2020

zeenix commented Aug 18, 2020

sdroege left a comment

sdroege commented Sep 3, 2020

zeenix commented Sep 3, 2020

zeenix commented Sep 3, 2020

sdroege commented Sep 3, 2020

Add container Variant API #651

Add container Variant API #651

Conversation

zeenix commented Jun 5, 2020

zeenix commented Jun 5, 2020

sdroege commented Jun 5, 2020

sdroege commented Jun 6, 2020

zeenix commented Jun 6, 2020

sdroege commented Jun 6, 2020

zeenix commented Jun 6, 2020

sdroege commented Jul 8, 2020

zeenix commented Jul 8, 2020

sdroege commented Jul 8, 2020

zeenix commented Jul 8, 2020

sdroege commented Aug 18, 2020

zeenix commented Aug 18, 2020

sdroege left a comment

Choose a reason for hiding this comment

sdroege commented Sep 3, 2020

zeenix commented Sep 3, 2020

zeenix commented Sep 3, 2020

sdroege commented Sep 3, 2020