Move ostree:// parsing to daemon
#3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to df8315a (coreos#3157). GNOME Software uses the D-Bus API directly, not the CLI. So let's move handling of `ostree://` there. The test added in coreos#3157 will verify that we're parsing it correctly. Closes: coreos#3192
lucab
approved these changes
Nov 2, 2021
|
Ah, yes oops. My bad for not actually testing gnome-software here 😦 |
cgwalters
approved these changes
Nov 2, 2021
|
@cgwalters @jlebon does this mean that the rebases from F34 to F35 through GNOME Software won't work? Becase we are getting some reports about it. If so, can you please do rpm-ostree hotfix build for F34? |
|
@tpopela yes, specifically the combination of an |
|
thank you @lucab ! Once there will be a bodhi update created please put the link here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to df8315a (#3157).
GNOME Software uses the D-Bus API directly, not the CLI. So let's move
handling of
ostree://there.The test added in #3157 will verify that we're parsing it correctly.
Closes: #3192