This repository has been archived by the owner on Sep 24, 2020. It is now read-only.
namespace: make MountFlags=shared work again #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since commit 0722b35, the root mountpoint is unconditionnally turned to slave which breaks units that are using explicitly MountFlags=shared (and no other options that would implicitly require a slave root mountpoint). Here is a test case: $ systemctl cat test-shared-mount-flag.service # /etc/systemd/system/test-shared-mount-flag.service [Service] Type=simple ExecStartPre=/usr/bin/mkdir -p /mnt/tmp ExecStart=/bin/sh -c "/usr/bin/mount -t tmpfs -o size=10M none /mnt/tmp && sleep infinity" ExecStop=-/bin/sh -c "/usr/bin/umount /mnt/tmp" MountFlags=shared $ systemctl start test-shared-mount-flag.service $ findmnt /mnt/tmp $ Mount on /mnt/tmp is not visible from the host although MountFlags=shared was used. This patch fixes that and turns the root mountpoint to slave when it's really required. (cherry picked from commit 37ed15d)
bgilbert
approved these changes
Apr 25, 2019
This was referenced Apr 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 37ed15d to fix coreos/bugs#2579.