This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
ftests: add functional tests #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeed
reviewed
May 24, 2017
| ) | ||
|
|
||
| func TestGeneratorEmpty(t *testing.T) { | ||
| if !IsInContainer() { |
There was a problem hiding this comment.
It's like forking, but better!
squeed
suggested changes
May 24, 2017
| cmd := exec.Command("torcx", "clearly-bogus") | ||
| err := cmd.Run() | ||
| if err == nil { | ||
| t.Error("expected error, got nil") |
There was a problem hiding this comment.
Probably want to check that the error code is not 253, which is rkt's exit code.
There was a problem hiding this comment.
Inception mode: everything here after the initial if block is run directly by testrunner inside a rkt container, so this line will never see any rkt error as it is only executed inside it. On the other hand, RunTestInContainer will propagate both rkt errors and tests failures back to the original runner.
There was a problem hiding this comment.
ahhhhhh, got that mixed up. Thanks!
squeed
approved these changes
May 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.