-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
) | ||
|
||
func TestGeneratorEmpty(t *testing.T) { | ||
if !IsInContainer() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's like forking, but better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion, otherwise looks good.
cmd := exec.Command("torcx", "clearly-bogus") | ||
err := cmd.Run() | ||
if err == nil { | ||
t.Error("expected error, got nil") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably want to check that the error code is not 253, which is rkt's exit code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inception mode: everything here after the initial if
block is run directly by testrunner inside a rkt container, so this line will never see any rkt error as it is only executed inside it. On the other hand, RunTestInContainer
will propagate both rkt errors and tests failures back to the original runner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhhhhh, got that mixed up. Thanks!
No description provided.