-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bot crashes when Slack thread pin limit is exceeded #15
Comments
We've had this one recently and I wonder if we should "just" not pin issues at all. They are always quickly available in the chat anyway so we don't strictly need it. |
There is a limit of 100 pinned threads in Slack and we currently don't handle that case properly. See: coreos#15
I guess we could live without it, the only downside is that for each issue/thread we would have to "click through" into history and hit "Resolve" there - which is slightly less convenient. Also if there's a huge amount of bug reports (with CVEs usually) the need for mass resolve still stands, although this is more of an RFE and not related to this issue. |
I've merged #16. This does not "fixes" this but works around it. We'll happily take a PR with the "full" fix 🙂. |
There seems to be a Slack limit set which prevents pinning more than 100 threads in a channel (not sure if this is server specific). The bot is pinning every Jira ticket it is set to watch and when it hits this limit it will crash because the exception is not handled now:
The bot could log a warning instead and skip pinning until the count is reduced in a channel.
A second part of the issue is recovering from a large amount of pinned messages. Currently any issue tracked by the bot can be untracked with "Resolve" button for each issue/thread posted in the channel. Similarly it can be unpinned one by one manually. It would be helpful to have a new command, similar to
refresh-all
that would allow mass resolving (and unpinning) issues after they've been assigned (resolve-all
?).The text was updated successfully, but these errors were encountered: