Backslashes 941170 #2345
Merged
Backslashes 941170 #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rule 941170's transformation pipeline was escaping the test payloads, so that when, for example, "javascript: \t" was being sent the "\t" was being interpreted as a literal tab character, which is not what we want here. The test needs to be for literal "\" and "t" characters. Adding additional backslashes works around the rule's transformations.
|
Meeting decision January: @emphazer will review this PR. |
|
@emphazer Can you take a look at this one? |
|
@fzipi sure i will do it this week |
|
i tested it with 10gb data and the matches are exactly the same. |
|
Awesome! Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves rule 941170 to use \x5c backslash representation and adds two tests for it.
As a bonus, the two existing tests for rule 941170 get Accept headers added (so that they no longer trigger rule 920300, "Request Missing an Accept Header").