Remove negative look behind: update rule 920120 #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theseion
changed the title
theseion
force-pushed
the
remove-negative-look-behind-update-rule-920120
branch
from
c9b29ed
to
bcb7c7e
Compare
|
@theseion I think you need to rebase this one after we merged the tests cleanup. |
theseion
force-pushed
the
remove-negative-look-behind-update-rule-920120
branch
from
bcb7c7e
to
a03adf4
Compare
|
Thanks, done. |
|
LGTM. @fgsch Now here is the core of the change, can you take a second look? |
|
LGTM too 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2360
This is PR 3 of 4 that replace #2360.