Removed special handling of \x5c in 930100-slashes.data #2426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This special handling is no longer required since regexp-assemble was updated Also fixed the regex creation comment since the shell doesn't reliably produce the regex (backslashes are stripped, depending on the tool and shell)
|
@RedXanadu Make sure that you've updated your regexp-assemble submodule, otherwise the hex escape will be converted. |
RedXanadu
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This special handling is no longer required since regexp-assemble was updated
Also fixed the regex creation comment since the shell doesn't reliably produce the regex (backslashes are stripped, depending on the tool and shell)