-
Notifications
You must be signed in to change notification settings - Fork 73
feat(upstream): use upstream nginx scaffolding #105
feat(upstream): use upstream nginx scaffolding #105
Conversation
b03948d
to
9afa8b3
Compare
3eae0f4
to
dc1990a
Compare
fdfab04
to
7fdc0f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why you duplicate the script that the NGiNX image already provides. The whole template magic works out of the box by placing files into the designated directory. I understand that it doesn't just work for templating files in other directories, but even there one could argue that you could just place all template files into the special templates directory and then move them somewhere else after envsubst
has done its work. You could take advantage of the fact that the script handles subdirectories gracefully, so you could place other templates into subdirectories. That way you know where they end up.
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
7fdc0f7
to
1f386ec
Compare
Ok, you are right, that worked. And simplifies that we don't need to change Apache. |
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM.
@theseion Needed to fix dns resolver because exporting the variable in a previous script didn't worked (which makes sense, once that you think about it). So ended up adding a new script that does sed on a fixed string instead, after templates are copied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, makes sense to replace DNS resolver statically.
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
467f026
to
abbd092
Compare
Signed-off-by: Felipe Zipitria felipe.zipitria@owasp.org
Should fix #104 .