Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IndexBundle] allow to query relations also by relation type #1156

Merged
merged 1 commit into from
Nov 6, 2019
Merged

[IndexBundle] allow to query relations also by relation type #1156

merged 1 commit into from
Nov 6, 2019

Conversation

dpfaffenbauer
Copy link
Member

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no

@dpfaffenbauer dpfaffenbauer added this to the 2.1.1 milestone Oct 31, 2019
@dpfaffenbauer dpfaffenbauer requested a review from a team October 31, 2019 11:17
@dpfaffenbauer dpfaffenbauer self-assigned this Oct 31, 2019
dpfaffenbauer
dpfaffenbauer commented Oct 31, 2019
View reviewed changes
src/CoreShop/Component/Index/Listing/ExtendedListingInterface.php

namespace CoreShop\Component\Index\Listing;

interface ExtendedListingInterface extends ListingInterface
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for introducing a BC break in the original ListingInterface

@dpfaffenbauer dpfaffenbauer merged commit 5c3d566 into coreshop:master Nov 6, 2019
@dpfaffenbauer dpfaffenbauer deleted the index-relation-type branch November 6, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dpfaffenbauer dpfaffenbauer

Labels
enhancement
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dpfaffenbauer