Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Store Values after Store has been removed #1171

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Remove Store Values after Store has been removed #1171

merged 1 commit into from
Nov 15, 2019

Conversation

solverat
Copy link
Contributor

Q A
Bug fix? sort of
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets --

After a store gets removed, all values in coreshop_product_store_values remain as orphans. This PR changes the coreshop_store constraint from SET NULL to CASCADE.

@dpfaffenbauer dpfaffenbauer merged commit d8b46ca into coreshop:master Nov 15, 2019
@solverat solverat deleted the store_cascade branch November 15, 2019 09:34
@solverat solverat added this to the 2.1.1 milestone Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpfaffenbauer dpfaffenbauer dpfaffenbauer approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@solverat @dpfaffenbauer