Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/concurrency #1549

Merged
merged 7 commits into from
Dec 29, 2020
Merged

Conversation

dpfaffenbauer
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no

The Problem we have quite often now is:

  • The Notify and the Capture Request come simultaneously
  • The Notify and Capture Controller read the Payment and update the same old Payment at quite the same time
  • These leads to a lot of issues: The workflow gets executed multiple times, States mess up, emails being sent multiple times, etc.
  • To fix this: We have to WRITE_LOCK the payment for the being of the request. This assures us that the second request, doesn't get to read the payment until the first one is finished. Since Payum doesn't support this out-of-the-box, we have to a be a bit tricky to do it....

@dpfaffenbauer dpfaffenbauer added this to the 2.2.7 milestone Dec 21, 2020
@dpfaffenbauer dpfaffenbauer self-assigned this Dec 21, 2020
@dpfaffenbauer dpfaffenbauer merged commit a4b3db3 into coreshop:2.2 Dec 29, 2020
@dpfaffenbauer dpfaffenbauer deleted the issues/concurrency branch December 29, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant