Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] remove country-aware currency context as it messes with the Storage Based Currency Context #1588

Merged
merged 5 commits into from Apr 12, 2021

Conversation

dpfaffenbauer
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no

@dpfaffenbauer dpfaffenbauer added this to the 2.2.10 milestone Feb 15, 2021
@dpfaffenbauer dpfaffenbauer requested a review from a team February 15, 2021 07:37
@dpfaffenbauer dpfaffenbauer self-assigned this Feb 15, 2021
@solverat
Copy link
Contributor

solverat commented Apr 11, 2021

to reproduce:

  • allow two currencies: one store "test" with base currency EUR and an additional currency CHF
  • go to GeoLiteBasedRequestResolver
  • add on top of method findCountry: return $this->countryRepository->findByCode("CH");
  • go to frontend for store "test": CHF is selected

=> incorrect - should be EUR until changes currency by triggering the switch-currency route.
=> it is also NOT possible to switch the currency because the forced selected currency gets overruled by CountryAwareCurrencyContext.

solverat
solverat previously approved these changes Apr 11, 2021
…orage Based Currency Context - also remove tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants