Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split customer and user into seperate entities #1669

Merged
merged 17 commits into from Jul 12, 2021

Conversation

dpfaffenbauer
Copy link
Member

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #665

This feature was dismissed in the 2.x branches and is now reintroduced. Basically a User and a Customer are completely different things and this PR handles that

# Conflicts:
#	src/CoreShop/Bundle/CoreBundle/Checkout/Step/AddressCheckoutStep.php
#	src/CoreShop/Bundle/CoreBundle/Checkout/Step/CustomerCheckoutStep.php
#	src/CoreShop/Bundle/CoreBundle/Customer/CustomerLoginService.php
#	src/CoreShop/Bundle/CoreBundle/Customer/CustomerLoginServiceInterface.php
#	src/CoreShop/Bundle/CoreBundle/Customer/RegistrationService.php
#	src/CoreShop/Bundle/CoreBundle/Event/RequestNewsletterConfirmationEvent.php
#	src/CoreShop/Bundle/CoreBundle/EventListener/NotificationRules/CustomerListener.php
#	src/CoreShop/Bundle/CoreBundle/Form/Type/CustomerRegistrationType.php
#	src/CoreShop/Bundle/CoreBundle/Form/Type/GuestRegistrationType.php
#	src/CoreShop/Bundle/CoreBundle/Resources/config/pimcore/coreshop/coreshop_customer.yml
#	src/CoreShop/Bundle/CoreBundle/Resources/config/pimcore/security.yml
#	src/CoreShop/Bundle/CoreBundle/Resources/config/services.yml
#	src/CoreShop/Bundle/CoreBundle/Resources/config/services/checkout.yml
#	src/CoreShop/Bundle/CoreBundle/Resources/config/services/context.yml
#	src/CoreShop/Bundle/CoreBundle/Resources/config/services/customer.yml
#	src/CoreShop/Bundle/CoreBundle/Resources/config/services/form.yml
#	src/CoreShop/Bundle/CoreBundle/Resources/install/pimcore/classes/CoreShopCustomerBundle/CoreShopCustomer.json
#	src/CoreShop/Bundle/CoreBundle/Security/ObjectUserProvider.php
#	src/CoreShop/Bundle/CustomerBundle/Form/Type/CustomerType.php
#	src/CoreShop/Bundle/CustomerBundle/Pimcore/Repository/CustomerRepository.php
#	src/CoreShop/Bundle/CustomerBundle/Resources/config/services.yml
#	src/CoreShop/Bundle/CustomerBundle/Resources/config/validation/Customer.yml
#	src/CoreShop/Bundle/FrontendBundle/Controller/CheckoutController.php
#	src/CoreShop/Bundle/FrontendBundle/Controller/RegisterController.php
#	src/CoreShop/Bundle/FrontendBundle/Resources/views/Customer/_header.html.twig
#	src/CoreShop/Bundle/FrontendBundle/Resources/views/Register/register.html.twig
#	src/CoreShop/Bundle/OrderBundle/Resources/public/pimcore/js/sale/detail/blocks/customer.js
#	src/CoreShop/Component/Core/Context/TokenBasedCustomerContext.php
#	src/CoreShop/Component/Core/Model/Cart.php
#	src/CoreShop/Component/Core/Model/CartInterface.php
#	src/CoreShop/Component/Core/Model/CompanyInterface.php
#	src/CoreShop/Component/Core/Model/Customer.php
#	src/CoreShop/Component/Core/Model/CustomerInterface.php
#	src/CoreShop/Component/Core/Model/OrderInterface.php
#	src/CoreShop/Component/Customer/Model/Customer.php
#	src/CoreShop/Component/Customer/Model/CustomerInterface.php
#	src/CoreShop/Component/Customer/Repository/CustomerRepositoryInterface.php
# Conflicts:
#	src/CoreShop/Behat/Context/Setup/CustomerContext.php
#	src/CoreShop/Behat/Context/Setup/FrontendSecurityContext.php
@dpfaffenbauer dpfaffenbauer added this to the 3.0.0 milestone Jul 7, 2021
@dpfaffenbauer dpfaffenbauer requested a review from a team July 7, 2021 08:10
@dpfaffenbauer dpfaffenbauer self-assigned this Jul 7, 2021
@dpfaffenbauer dpfaffenbauer merged commit ea4ad22 into coreshop:master Jul 12, 2021
@dpfaffenbauer dpfaffenbauer deleted the 3.0-features/split-user branch April 15, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant