-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CoreShop3] Added payum payment model fields to coreshop payment model #1854
Conversation
@BabovicT what is failing cause of missing fields? |
@dpfaffenbauer because of totalAmount not being in database amount paid is always 0. If we use for example paypal, it will be charged correct amount from it but in administration order would still be in state "awaiting payment". Same thing if we try to add payment through admin. |
ok, interesting. I tried avoiding these fields since we don't need them. I will look into the root cause of this issue |
There was already totalAmount, currencyCode and details fields in payment.php so i tought you just forgot to add them in orm. Glad that at least i pointed to this problem. You can close this pr then. |
I'll keep it open for now, maybe this is the solution anyway. But I'll check it |
@BabovicT I changed the PR. CientId and ClientEmail is never used. Other than that everything is perfect |
@BabovicT thanks |
With Payment model not longer extending Payum/Payment model there is issue with orm mapping. Not all columns are being created in database. Also payment is not working because some fields couldn't be mapped because of that.
This is proposition for first hand solution so that when someone installs CoreShop 3 payment works.