Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoreShop3] Added payum payment model fields to coreshop payment model #1854

Merged
merged 3 commits into from Feb 17, 2022

Conversation

BabovicT
Copy link
Contributor

@BabovicT BabovicT commented Feb 3, 2022

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no

With Payment model not longer extending Payum/Payment model there is issue with orm mapping. Not all columns are being created in database. Also payment is not working because some fields couldn't be mapped because of that.
This is proposition for first hand solution so that when someone installs CoreShop 3 payment works.

@BabovicT BabovicT changed the title Added payum payment model fields to coreshop payment model [CoreShop3] Added payum payment model fields to coreshop payment model Feb 3, 2022
@CLAassistant
Copy link

CLAassistant commented Feb 3, 2022

CLA assistant check
All committers have signed the CLA.

@dpfaffenbauer
Copy link
Member

@BabovicT what is failing cause of missing fields?

@BabovicT
Copy link
Contributor Author

BabovicT commented Feb 4, 2022

@dpfaffenbauer because of totalAmount not being in database amount paid is always 0. If we use for example paypal, it will be charged correct amount from it but in administration order would still be in state "awaiting payment". Same thing if we try to add payment through admin.
Other columns are not connected to that but some data is not being saved to database because it was missing.
As I already wrote, this is just so fresh install can process payments. We are currently trying CoreShop 3(we have prihect in Pimcore X) so far thus was only thing missing for it to function like it was before.

@BabovicT
Copy link
Contributor Author

BabovicT commented Feb 4, 2022

image
This is from Your demo site.

image
As you can see there is no totalAmount column so every payment is always displayed as 0.

@dpfaffenbauer
Copy link
Member

ok, interesting. I tried avoiding these fields since we don't need them. I will look into the root cause of this issue

@BabovicT
Copy link
Contributor Author

BabovicT commented Feb 4, 2022

There was already totalAmount, currencyCode and details fields in payment.php so i tought you just forgot to add them in orm. Glad that at least i pointed to this problem. You can close this pr then.

@dpfaffenbauer
Copy link
Member

I'll keep it open for now, maybe this is the solution anyway. But I'll check it

@dpfaffenbauer
Copy link
Member

@BabovicT I changed the PR. CientId and ClientEmail is never used. Other than that everything is perfect

@dpfaffenbauer dpfaffenbauer merged commit d578a8c into coreshop:master Feb 17, 2022
@dpfaffenbauer
Copy link
Member

@BabovicT thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants