FIX: localized fields from brick and fieldcollections can be added to index #1872
Conversation
FIX:double click on field group adds them to indices
Update psalm.xml
|
psalm issue is fixed: #1873, can you rebase? |
|
@dominikager I also added Helper for inheritance to localizedFieldGetter. |
|
@BabovicT Changed to how I imagine it, can you check and test pls? |
| } | ||
|
|
||
| if ($fd instanceof Localizedfield) { |
There was a problem hiding this comment.
@dpfaffenbauer I think it would work but $fd is not instance of LocalizedField. It is instance of field under the localizedfields. Thats why I used
if ($item->getDefinition()->getFieldDefinition('localizedfields')) {
There was a problem hiding this comment.
but that only checks if there are localized-fields in the fieldcollection... which is useless basically. We need to know if the selected field is localized or not. But I see that there is an issue here. I will check again.
There was a problem hiding this comment.
For some reason that checks if that field is inside localized-fields. If you have input and localized input that will be true only for localized input. Not sure why is that the case tho.
There was a problem hiding this comment.
changed some more, worked for me now.
|
Working for me too. |
|
thanks @BabovicT |
Brick and fieldcollections with localazied fields are now indexable.