Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: select from multiselect throws error if no value is pre-selected #1880

Merged
merged 2 commits into from Mar 2, 2022

Conversation

BabovicT
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets

If you create select from multiselect filter and don't preselect the value exception is thorwn. trim(): Argument #1 ($string) must be of type string, null given.

@dpfaffenbauer
Copy link
Member

@BabovicT can you please rebase

@BabovicT
Copy link
Contributor Author

BabovicT commented Mar 2, 2022

@dpfaffenbauer Rebased

@dpfaffenbauer dpfaffenbauer self-requested a review March 2, 2022 14:18
@dpfaffenbauer dpfaffenbauer added this to the 3.0.0 milestone Mar 2, 2022
@dpfaffenbauer dpfaffenbauer merged commit 39c4472 into coreshop:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants