[ResourceBundle] Make stack of classes not extended in CoreBundle working #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhoeck
changed the title
|
@davidhoeck can you please rebase |
|
rebase on what? @dpfaffenbauer |
|
@davidhoeck master to fix the tests |
|
@dpfaffenbauer should be done |
dpfaffenbauer
approved these changes
Mar 2, 2022
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stack for
coreshop.manufacturerandcoreshop.addresswas not working, because the classes have not been extended in the CoreBundle. Therefore I adjusted the check in the StackClassesPass to also work with not extended classes.