Fix non unique typename #2004
Merged
Fix non unique typename #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@C-R-W please sign the CLA and check why tests are failing now |
dpfaffenbauer
requested changes
Jun 9, 2022
src/CoreShop/Bundle/PimcoreBundle/DataHub/Type/SerializedDataType.php
Outdated
Show resolved
Hide resolved
src/CoreShop/Bundle/PimcoreBundle/DataHub/QueryType/SerializedData.php
Outdated
Show resolved
Hide resolved
|
@C-R-W Tests fail for other reasons, I still have some comments |
|
Hi, i updated the files, is this ok so? |
dpfaffenbauer
requested changes
Jul 7, 2022
src/CoreShop/Bundle/PimcoreBundle/DataHub/QueryType/SerializedData.php
Outdated
Show resolved
Hide resolved
dpfaffenbauer
approved these changes
Aug 24, 2022
|
thanks @C-R-W |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix non unique type name.
Bug:
If there is more then one SerializedDataType in a schema entity a exception gets thrown.
Uncaught PHP Exception GraphQL\Error\InvariantViolation: "Schema must contain unique named types but contains multiple types named "coreShopSerializedData" (see http://webonyx.github.io/graphql-php/type-system/#type-registry)." at /var/www/vhosts/portal.prooptik.de/pimcore-live/vendor/webonyx/graphql-php/src/Utils/Utils.php line 333 {"exception":"[object] (GraphQL\Error\InvariantViolation(code: 0): Schema must contain unique named types but contains multiple types named "coreShopSerializedData" (see http://webonyx.github.io/graphql-php/type-system/#type-registry). at /var/www/vhosts/portal.prooptik.de/pimcore-live/vendor/webonyx/graphql-php/src/Utils/Utils.php:333)"