Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dirname() and basename() to expression function provider #2007

Merged
merged 1 commit into from May 28, 2022
Merged

feat: add dirname() and basename() to expression function provider #2007

merged 1 commit into from May 28, 2022

Conversation

dkarlovi
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets N/A

These functions are a common requirement if your expressions deal with paths.

@dkarlovi
Copy link
Contributor Author

Failures unrelated.

@dpfaffenbauer dpfaffenbauer merged commit 26939e5 into coreshop:master May 28, 2022
@dpfaffenbauer
Copy link
Member

thanks

@dpfaffenbauer dpfaffenbauer added this to the 3.0.0 milestone May 28, 2022
@dkarlovi dkarlovi deleted the patch-3 branch June 9, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpfaffenbauer dpfaffenbauer dpfaffenbauer approved these changes

Assignees

@dkarlovi dkarlovi

Labels
enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dkarlovi @dpfaffenbauer