Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pimcore UI] Make default Product Unit unselectable #2065

Merged

Conversation

aarongerig
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #2040

I'm not 100% sure if this is the correct place to fix the issue of not having an empty entry in the store. @dpfaffenbauer Could you please check and advise if there's a "better way" of adding an empty entry to a CoreShop resource list.
Thanks!

@aarongerig aarongerig changed the title fix: make default product unit unselectable [Pimcore UI] Make default Product Unit unselectable Sep 6, 2022
@dpfaffenbauer dpfaffenbauer added this to the 3.0.0 milestone Sep 7, 2022
@dpfaffenbauer dpfaffenbauer merged commit 3f07976 into coreshop:master Sep 7, 2022
@dpfaffenbauer
Copy link
Member

thanks a lot @aarongerig

@aarongerig aarongerig deleted the fix/default-product-unit-selector branch September 7, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants