Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CustomerAssignment] Fix typo when passing the company ID to the router #2102

Merged
merged 1 commit into from Nov 8, 2022

Conversation

aarongerig
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no

Before this PR the following URL is generated:

/admin/coreshop/customer-company-modifier/dispatch-existing-assignment/16685/undefined

Which leads to following error:

CoreShop\Bundle\CoreBundle\Controller\CustomerTransformerController::dispatchExistingAssignmentAction():
Argument #3 ($companyId) must be of type int, string given

With this PR, the correct company ID gets passed to the router and there generates the correct URL.

@dpfaffenbauer dpfaffenbauer merged commit 28f8136 into coreshop:master Nov 8, 2022
@dpfaffenbauer
Copy link
Member

thanks @aarongerig

@aarongerig aarongerig deleted the patch-3 branch November 8, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants