Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StorageListItem] add definitive StorageList (Order/Wishlist) field to Item #2117

Merged
merged 4 commits into from Nov 20, 2022

Conversation

dpfaffenbauer
Copy link
Member

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #2115

@TobiSW This is a different approach to the issue. This solves the underlying issue of the relation between order and order-item (eg. storage-list and storage-list-item).

@dkarlovi @solverat @breakone Any thoughts on that?

@dpfaffenbauer dpfaffenbauer added this to the 3.1.0 milestone Nov 18, 2022
@dpfaffenbauer dpfaffenbauer requested a review from a team November 18, 2022 07:41
@dpfaffenbauer dpfaffenbauer self-assigned this Nov 18, 2022
@solverat
Copy link
Contributor

Mhmm. It would be interesting to know why the message appears at all. Is it because in V2 the objects were saved more often?

However, it's a relation more but also no more do/while magic.

@dpfaffenbauer
Copy link
Member Author

dpfaffenbauer commented Nov 18, 2022

@solverat It happens because the order gets moved and processed before saved. so the items are still in the old location. so the parent is basically not there anymore for the item

@solverat
Copy link
Contributor

Ah I see, that's because of the cart/order behavior (same object)!

Well, that's going to be a heavy migration then. :)

@dpfaffenbauer
Copy link
Member Author

@solverat exactly. About the migration: Well, yes... There is the other PR #2116 too, which just does a save before doing the calculations.

But I think in the long term, it is better to have a real relation between the two.

@dpfaffenbauer dpfaffenbauer merged commit b4671bf into coreshop:master Nov 20, 2022
@dpfaffenbauer dpfaffenbauer deleted the issues/2115-2 branch November 20, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants