Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added event.js on ResourceBundle #2228

Merged
merged 1 commit into from Mar 6, 2023

Conversation

zoidbergx
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #2189

Added event.js on ResourceBundle to avoid an undefined event if using the ResourceBundle standalone

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2023

CLA assistant check
All committers have signed the CLA.

@dpfaffenbauer
Copy link
Member

@zoidbergx please rebase to 3.x

@zoidbergx zoidbergx changed the base branch from master to 3.0 March 6, 2023 09:41
@zoidbergx zoidbergx changed the base branch from 3.0 to master March 6, 2023 09:41
@zoidbergx zoidbergx changed the base branch from master to 3.0 March 6, 2023 09:42
@zoidbergx zoidbergx force-pushed the #2189-fix-undefined-events branch 2 times, most recently from d806b5f to 33ce823 Compare March 6, 2023 09:47
@zoidbergx zoidbergx closed this Mar 6, 2023
@zoidbergx zoidbergx reopened this Mar 6, 2023
@zoidbergx
Copy link
Contributor Author

@dpfaffenbauer should hopefully be correct now

@dpfaffenbauer dpfaffenbauer merged commit a0e0b62 into coreshop:3.0 Mar 6, 2023
@dpfaffenbauer
Copy link
Member

thanks @zoidbergx

@zoidbergx zoidbergx deleted the #2189-fix-undefined-events branch March 6, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants