Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WishlistBundle] new feature: wishlist cleaner #2234

Merged
merged 12 commits into from Apr 7, 2023
Merged

[WishlistBundle] new feature: wishlist cleaner #2234

merged 12 commits into from Apr 7, 2023

Conversation

alexloetscher95
Copy link
Contributor

@alexloetscher95 alexloetscher95 commented Mar 14, 2023 •
edited

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no

Adds the posibility to clean up old wishlists similar to the CartExpireTask

Similar to the CartExpireTask, the expiration is deactivated by default and can be activated by following configuration (example):

core_shop_order:
    expiration:
        wishlist:
            days: 20
            anonymous: true
            customer: false

@CLAassistant
Copy link

CLAassistant commented Mar 14, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@alexloetscher95 alexloetscher95 marked this pull request as draft March 14, 2023 17:35
@dpfaffenbauer dpfaffenbauer marked this pull request as ready for review March 17, 2023 10:38
@dpfaffenbauer dpfaffenbauer self-requested a review March 17, 2023 10:39
@dpfaffenbauer dpfaffenbauer added this to the 3.0.5 milestone Mar 17, 2023
@dpfaffenbauer
Copy link
Member

@alexloetscher95 you are happy so far with it right?

@alexloetscher95
Copy link
Contributor Author

@dpfaffenbauer Yes, absolutely. I have tested it on a client project and it works as desired.

dpfaffenbauer
dpfaffenbauer reviewed Apr 3, 2023
View reviewed changes
src/CoreShop/Bundle/WishlistBundle/Resources/config/pimcore/config.yml Outdated
service: CoreShop\Bundle\OrderBundle\Expiration\OrderAndCartExpiration
params:
cart:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't make sense for wishlist

@dpfaffenbauer
Copy link
Member

@alexloetscher95 nice, I will check the PR again this week and then merge it

@dpfaffenbauer dpfaffenbauer modified the milestones: 3.0.5, 3.1.0 Apr 6, 2023
@dpfaffenbauer dpfaffenbauer merged commit 6f6c54e into coreshop:master Apr 7, 2023
207 checks passed
@dpfaffenbauer
Copy link
Member

@alexloetscher95 thanks a lot for kicking this off and helping with it :)

@alexloetscher95 alexloetscher95 deleted the feat/wishlist-cleaner branch April 11, 2023 13:15
@aarongerig
Copy link
Contributor

Any chance to get a release for this feature? :)

@dpfaffenbauer
Copy link
Member

will be part of 3.1

@aarongerig
Copy link
Contributor

Any ETA? Just so I know, if I have to come up with another plan... 😉

@dpfaffenbauer
Copy link
Member

about 1-2 weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpfaffenbauer dpfaffenbauer dpfaffenbauer approved these changes

Assignees

@dpfaffenbauer dpfaffenbauer

@alexloetscher95 alexloetscher95

Labels
enhancement
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexloetscher95 @CLAassistant @dpfaffenbauer @aarongerig