Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use invoice address of logged in customer for tax calculation #2254

Merged
merged 2 commits into from Apr 19, 2023

Conversation

BlackbitDevs
Copy link
Contributor

@BlackbitDevs BlackbitDevs commented Apr 18, 2023

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no

Assume we have a store with base country DE:
Bildschirmfoto 2023-04-18 um 14 02 26

And we have tax rule 19% VAT for country Germany and 0% VAT for all other countries:
Bildschirmfoto 2023-04-18 um 14 02 05

Initially without being logged-in the taxes shown on the website will be based on the store's base country. This is correct.
But when the client logs in, we already know his default address. In the checkout this gets used anyway but not when browsing through the site. On the site we still see taxes based on the store's base country.
With this PR the logged-in customer's address will get used for displaying taxes also when browsing the shop.

@BlackbitDevs BlackbitDevs marked this pull request as ready for review April 18, 2023 12:33
@dpfaffenbauer dpfaffenbauer added this to the 3.0.5 milestone Apr 19, 2023
@dpfaffenbauer dpfaffenbauer merged commit 44fd967 into coreshop:3.0 Apr 19, 2023
208 checks passed
@dpfaffenbauer
Copy link
Member

thanks @BlackbitDevs

@BlackbitDevs BlackbitDevs changed the title Use shipping address of logged in customer for tax calculation Use invoice address of logged in customer for tax calculation Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants