Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in the filter functionality for multiselects #2426

Merged
merged 1 commit into from Oct 30, 2023
Merged

Fix error in the filter functionality for multiselects #2426

merged 1 commit into from Oct 30, 2023

Conversation

hethehe
Copy link
Contributor

@hethehe hethehe commented Oct 30, 2023

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #2425

This PR fix an error in the filter functionality if you use any filter with multiple values (multiselects)

Since Symfony 6 we can't get a non scalar value form $parameterBag->get().
Symfony 5 triggered following deprecation note:

Retrieving a non-scalar value from "$parameterBag->get()" is deprecated, and will throw a "%s" exception in Symfony 6.0, use "%s::all($key)" instead.

@dpfaffenbauer dpfaffenbauer added this to the 4.0.0 milestone Oct 30, 2023
@dpfaffenbauer dpfaffenbauer self-requested a review October 30, 2023 08:22
@dpfaffenbauer
Copy link
Member

thanks a lot @hethehe

@dpfaffenbauer dpfaffenbauer merged commit 8739a49 into coreshop:4.0 Oct 30, 2023
140 checks passed
@hethehe hethehe mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpfaffenbauer dpfaffenbauer dpfaffenbauer approved these changes

Assignees

@hethehe hethehe

Labels
bug
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hethehe @dpfaffenbauer