Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution/setting up dev enviornment #2576

Merged

Conversation

TanaseTeofil
Copy link
Contributor

@TanaseTeofil TanaseTeofil commented Mar 6, 2024

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #...

#2575

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2024

CLA assistant check
All committers have signed the CLA.

@dpfaffenbauer
Copy link
Member

@TanaseTeofil please sign the CLA

LOVE IT!

@dpfaffenbauer
Copy link
Member

@TanaseTeofil please sign the CLA

@TanaseTeofil TanaseTeofil marked this pull request as ready for review March 21, 2024 14:56
build:
target: dev
args:
uid: ${USER_ID:-1000}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just a linux thing and doesn't work on mac or windows. should we leave that just commented out?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, this is not compatible with docker desktop. On windows, one could shell into the Docker VM and run the commands there, and I guess that this is what the majority is doing. There it should work same as on a native Linux distro. But this will not work with Mac as far as I know.

I guess simply commenting this out here will cause breakage elsewhere in the setup. Let me and @TanaseTeofil better try to add docker desktop support here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've updated the guide to support Docker Desktop so that it can work on Windows and Mac as well.
We will provide native Linux docker setup later today or in the following days for people on Linux who do not wish to use Docker Desktop.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@dpfaffenbauer
Copy link
Member

@TanaseTeofil @yariksheptykin is this ready?

@TanaseTeofil
Copy link
Contributor Author

@TanaseTeofil @yariksheptykin is this ready?

I would say it is. @yariksheptykin thoughts?

@dpfaffenbauer
Copy link
Member

fine, I'll give it a test then :)

@dpfaffenbauer
Copy link
Member

@TanaseTeofil I love it! I made some smaller changes. If you are happy with them too, we can merge it :)

@TanaseTeofil
Copy link
Contributor Author

@TanaseTeofil I love it! I made some smaller changes. If you are happy with them too, we can merge it :)

Cool! Feel free to merge it any time :)

docker-compose.yaml Outdated Show resolved Hide resolved
@dpfaffenbauer dpfaffenbauer merged commit 6272e01 into coreshop:3.2 Apr 29, 2024
142 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants