Contribution/setting up dev enviornment #2576
Conversation
|
|
|
@TanaseTeofil please sign the CLA LOVE IT! |
|
@TanaseTeofil please sign the CLA |
| build: | ||
| target: dev | ||
| args: | ||
| uid: ${USER_ID:-1000} |
There was a problem hiding this comment.
this is just a linux thing and doesn't work on mac or windows. should we leave that just commented out?
There was a problem hiding this comment.
You are right, this is not compatible with docker desktop. On windows, one could shell into the Docker VM and run the commands there, and I guess that this is what the majority is doing. There it should work same as on a native Linux distro. But this will not work with Mac as far as I know.
I guess simply commenting this out here will cause breakage elsewhere in the setup. Let me and @TanaseTeofil better try to add docker desktop support here.
There was a problem hiding this comment.
We've updated the guide to support Docker Desktop so that it can work on Windows and Mac as well.
We will provide native Linux docker setup later today or in the following days for people on Linux who do not wish to use Docker Desktop.
|
@TanaseTeofil @yariksheptykin is this ready? |
I would say it is. @yariksheptykin thoughts? |
|
fine, I'll give it a test then :) |
|
@TanaseTeofil I love it! I made some smaller changes. If you are happy with them too, we can merge it :) |
Cool! Feel free to merge it any time :) |
#2575