Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translatable labels for payment-provider-rules #2625

Conversation

nehlsen
Copy link
Contributor

@nehlsen nehlsen commented May 7, 2024

Added translatable labels for payment-provider-rules

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #...

BEFORE
coreshop-add-localized-label-to-payment-provider-rules-before

AFTER
coreshop-add-localized-label-to-payment-provider-rules-after

@nehlsen nehlsen changed the title add translation for default payment provider rule label Translatable labels for payment-provider-rules May 7, 2024
@nehlsen nehlsen marked this pull request as ready for review May 7, 2024 13:48
Copy link
Member

@dpfaffenbauer dpfaffenbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely work, just the migration and then we are good to go.

Thank you very much @nehlsen

Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
5.1% Duplication on New Code

See analysis details on SonarCloud

@dpfaffenbauer dpfaffenbauer merged commit 354c09e into coreshop:4.0 May 9, 2024
277 checks passed
@dpfaffenbauer
Copy link
Member

thanks a lot @nehlsen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants