Spaces in installation path are properly handled by nvm install, but not by nvm use

[janerjak]

Issue:
When installing nvm-windows using the nvm-setup.exe to a path with spaces, e.g. "C:\Programs X", the command nvm install latest successfully runs. nvm use latest will return a non-zero exit-code and produce the output
exit status 1: 'C:\Programs' is not recognized as an internal or external command, operable program or batch file.

How To Reproduce:

1. Install nvm using nvm-setup.exe (version 1.1.1.0, launched with admin privileges) to a path containing spaces
2. Open a terminal window and type nvm install latest (this should work)
3. Type nvm use latest
4. See error

Expected Behavior:
nvm selecting the correct version

Screenshots:

Notes: The screenshot is taken from a terminal running MINGW64. The bug is also present in Command Line (Windows 11) and Power Shell.

Desktop:

• OS: Windows 11 22H2

[iquanxin]

Check your environment PATH

[janerjak]

Check your environment PATH

Sorry, what exactly should I check? Installing at a path without spaces works like a charm (which I ultimately did).

Nevertheless, this should be fixed at some point.

[Plagiatus]

Having the same issue on Win10 Pro Build 19044, using nvm 1.1.10. Possibly related to #355 ?

[lava-floor]

Hi, I've encountered the same issue; solved running cmd as Administrator

[nineninesevenfour]

I suggest to fix it by wrapping arguments with an escape function in nvm.go:

func run(name string, arg ...string) (bool, error) {
	c := exec.Command(name, escape(arg)...)
	// ... rest of function
}

func escape(args []string) []string {
	for index, arg := range args {
		if strings.Contains(arg, " ") && !strings.HasPrefix(arg, "\"") {
			args[index] = "\"" + arg + "\""
		}
	}
	return args
}

As far as I have seen this should work with current usages, but I did not test it.

[nineninesevenfour]

It turned out, that spaces in the arguments was not the problem. The problem was that exec.Command(...) refuses to execute commands with spaces in it. Quoting the command did not work as well. But setting Dir in type Cmd worked.
PR follows.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This issue was closed because it has been stalled for 7 days with no activity.