Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issue.Fix node_mirror, npm_mirror not work issue.Add cleanup work when download is interrupted by user. #251

Merged
merged 4 commits into from
Mar 8, 2017

Conversation

Excited-ccccly
Copy link
Contributor

Let me talk about this pull request from the beginning.

I live in China, therefore downloading directly from nodejs.org or GitHub is so slow which is frustrating.

I want to use a mirror to speed up downloading, but I found that neither nvm node_mirror nor nvm npm_mirror would work.Then I use ctrl+c to interrupt the download process and try again.But I found that nvm told me that the version is already installed.Then I digged into the nvm directory and found there was a folder of the version which I interrupt.

So I fix node_mirror, npm_mirror not work issue and add cleanup work when download is interrupted by user.

Copy link
Owner

@coreybutler coreybutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the fact you added rollback support for interrupted downloads. Overall, this looks good. Let me run a few tests to confirm, then I'll merge and release. Thank you!

@coreybutler coreybutler merged commit 3dd9ec3 into coreybutler:master Mar 8, 2017
@phtwo
Copy link

phtwo commented Mar 20, 2017

There seems to be a problem.
nvm node_mirror should print the value but reset node_mirror to empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants