Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#268 Fixed comparison in exceeds latest #269

Merged
merged 1 commit into from May 10, 2017
+13 −6
Merged

#268 Fixed comparison in exceeds latest #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/nvm.go
View file
Open in desktop
Expand Up @@ -12,6 +12,7 @@ import (
"./nvm/arch"
"./nvm/file"
"./nvm/node"
"strconv"
"github.com/olekukonko/tablewriter"
)

Expand Down Expand Up @@ -144,12 +145,19 @@ func CheckVersionExceedsLatest(version string) bool{
re := regexp.MustCompile("node-v(.+)+msi")
reg := regexp.MustCompile("node-v|-x.+")
latest := reg.ReplaceAllString(re.FindString(content),"")

if version <= latest {
return false
} else {
return true
var vArr = strings.Split(version,".")
var lArr = strings.Split(latest, ".")
for index := range lArr {
lat,_ := strconv.Atoi(lArr[index])
ver,_ := strconv.Atoi(vArr[index])
//Should check for valid input (checking for conversion errors) but this tool is made to trust the user
if ver < lat {
return false
} else if ver > lat {
return true
}
}
return false
}

func install(version string, cpuarch string) {
Expand Down Expand Up @@ -197,7 +205,6 @@ func install(version string, cpuarch string) {
fmt.Println("Node.js v"+version+" is not yet released or available.")
return
}

if cpuarch == "64" && !web.IsNode64bitAvailable(version) {
fmt.Println("Node.js v"+version+" is only available in 32-bit.")
return
Expand Down