Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added console messages indicating to the user that npm installed successfully #784

Closed
wants to merge 1 commit into from
Closed

Added console messages indicating to the user that npm installed successfully #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ go 1.16

require (
github.com/blang/semver v3.5.1+incompatible // indirect
github.com/coreybutler/go-fsutil v1.1.1 // indirect
github.com/coreybutler/go-fsutil v1.2.0 // indirect
github.com/olekukonko/tablewriter v0.0.5 // indirect
)
2 changes: 2 additions & 0 deletions src/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ github.com/coreybutler/go-fsutil v1.1.0 h1:HSp9qewM4XspmJJDi4p/QxSSVQTAhn2AlqJxQ
github.com/coreybutler/go-fsutil v1.1.0/go.mod h1:B+6ufEkkRZgFwyR2sHEVG9dMzVBU3GbyGyYmCq7YkEk=
github.com/coreybutler/go-fsutil v1.1.1 h1:ec295Tjnk/BEP/TdiyoaYhtg5/8qcM+BfVyhpjr/6ts=
github.com/coreybutler/go-fsutil v1.1.1/go.mod h1:B+6ufEkkRZgFwyR2sHEVG9dMzVBU3GbyGyYmCq7YkEk=
github.com/coreybutler/go-fsutil v1.2.0 h1:kbm62NSofawglUppEOhpHC3NDf/J7ZpguBirBnsgUwU=
github.com/coreybutler/go-fsutil v1.2.0/go.mod h1:B+6ufEkkRZgFwyR2sHEVG9dMzVBU3GbyGyYmCq7YkEk=
github.com/mattn/go-runewidth v0.0.9 h1:Lm995f3rfxdpd6TSmuVCHVb/QhupuXlYr8sCI/QdE+0=
github.com/mattn/go-runewidth v0.0.9/go.mod h1:H031xJmbD/WCDINGzjvQ9THkh0rPKHF+m2gUSrubnMI=
github.com/olekukonko/tablewriter v0.0.5 h1:P2Ga83D34wi1o9J6Wh1mRuqd4mF/x/lgBS7N7AbDhec=
Expand Down
4 changes: 3 additions & 1 deletion src/nvm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,9 @@ func install(version string, cpuarch string) {
}

if file.Exists(filepath.Join(env.root, "v"+version, "node_modules", "npm")) {
fmt.Println("\n\nInstallation complete. If you want to use this version, type\n\nnvm use " + version)
npmv := getNpmVersion(version)
fmt.Println("npm v"+npmv+" installed successfully.")
fmt.Println("\nInstallation complete. If you want to use this version, type\n\nnvm use " + version)
return
}

Expand Down
4 changes: 2 additions & 2 deletions src/web/web.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ func GetNodeJS(root string, v string, a string, append bool) bool {
if Download(url, fileName, v) {
// Extract the zip file
if strings.HasSuffix(url, ".zip") {
fmt.Println("Extracting...")
fmt.Println("Extracting node and npm...")
err := unzip(fileName, root+"\\v"+v)
if err != nil {
fmt.Println("Error extracting from Node archive: " + err.Error())
Expand Down Expand Up @@ -179,7 +179,7 @@ func GetNodeJS(root string, v string, a string, append bool) bool {
fmt.Printf("Failed to remove %v after successful extraction. Please remove manually.", zip)
}
}
fmt.Printf("Complete\n")
fmt.Println("Complete")
return true
} else {
return false
Expand Down