Use Binary Search Instead of HashMap #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o binary-search * 'binary-search' of github.com:coreyja/devicon-lookup: Macbook results
|
Blog Post Published: https://coreyja.com/blog/2019/02/03/devicon-binary-search.html Going to close this pull request, I don't think I want to go with a Binary Search, especially with the cache |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a a BinarySearch instead of the HashMap for looking up the devicons.
This was supposed to be a performance improvement, and I do NOT believe that this actually was an improvement.
Wanted to preserve the branch, so partially doing that with this PR. I will likely also write a quick blog post about it which I will likely copy to the PR, and/or link to this PR from the blog.