Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Legacy Inference Support and Base Conversion Logic for torch.nn.RNN Layers #134

Merged
merged 3 commits into from
Apr 13, 2022

Conversation

coreylammie
Copy link
Owner

Implemented legacy inference support and base conversion logic for torch.nn.RNN layers (as a precursor to full support).

@lgtm-com
Copy link

lgtm-com bot commented Apr 13, 2022

This pull request introduces 6 alerts when merging f0547a8 into 30251e0 - view on LGTM.com

new alerts:

  • 6 for Unused import

coreylammie and others added 2 commits April 13, 2022 13:33
Co-authored-by: coreylammie <coreylammie@users.noreply.github.com>
@lgtm-com
Copy link

lgtm-com bot commented Apr 13, 2022

This pull request introduces 6 alerts when merging ff45a27 into 30251e0 - view on LGTM.com

new alerts:

  • 6 for Unused import

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #134 (ff45a27) into master (30251e0) will decrease coverage by 3.54%.
The diff coverage is 25.69%.

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   84.21%   80.66%   -3.55%     
==========================================
  Files          54       55       +1     
  Lines        2293     2421     +128     
==========================================
+ Hits         1931     1953      +22     
- Misses        362      468     +106     
Flag Coverage Δ
unittests 80.66% <25.69%> (-3.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
memtorch/mn/RNN.py 15.17% <15.17%> (ø)
memtorch/mn/Module.py 72.83% <30.76%> (-8.59%) ⬇️
tests/conftest.py 93.02% <83.33%> (-4.42%) ⬇️
memtorch/mn/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30251e0...ff45a27. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant