Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum changes for occupancy API #180

Merged
merged 5 commits into from
Sep 25, 2023
Merged

Conversation

Jark5455
Copy link
Contributor

@Jark5455 Jark5455 commented Sep 15, 2023

Hello,

Here is a draft pull request for #102. These are only the minimum changes (no docs, default parameters, etc..)

Copy link
Owner

@coreylowman coreylowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me, can you run cargo fmt and then I can merge

@Jark5455
Copy link
Contributor Author

Jark5455 commented Sep 18, 2023

I believe it is failing because of a change that isn't made by me. The Cudnn::new function is returning an Arc to a Cudnn handle even though it shouldn't be able to since Cudnn handles are not thread safe.

here is the problematic code

According to nvidias cuDNN developer guide

"The cuDNN library is thread-safe. Its functions can be called from multiple host threads, so long as the threads do not share the same cuDNN handle simultaneously."

@coreylowman
Copy link
Owner

Actually you don't need to fix the Arc, I can fix that separately - Can you revert that change but keep the cargo fmt? I will manually merge even though the piplines fail 😄

@Jark5455
Copy link
Contributor Author

Sorry about that, im struggling with git a bit, I think its good now.

@coreylowman coreylowman merged commit 54f363a into coreylowman:main Sep 25, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants