Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial merging of nvidia-smi and nvcc checks #685

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Initial merging of nvidia-smi and nvcc checks #685

merged 1 commit into from
Apr 10, 2023

Conversation

quietlychris
Copy link
Contributor

This addresses the discussion in #683. I've checked that this compiles with features=nightly,cuda on my machine, but if this doesn't work for you or I misunderstood what you had in mind, just let me know!

coreylowman
coreylowman approved these changes Apr 10, 2023
View reviewed changes
Copy link
Owner

@coreylowman coreylowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this looks good to me - I'll probably also add a check for compute_cap in the nvcc codes and panic with a helpful message if not. That should be very unlikely, but good to cover all the bases.

@coreylowman coreylowman merged commit cc4a0b6 into coreylowman:main Apr 10, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreylowman coreylowman coreylowman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quietlychris @coreylowman