Support Technic Hub (bb0961c01)

[alwayslinux2]

Technic hub has 4 ports (instead of 2 like the powered up hub), and does not understand port AB, so anything calling for AB has to be two commands, one for port A and one for port B.

[alwayslinux2]

Technic hub has 4 ports (instead of 2 like the powered up hub), and does not understand port AB, so anything calling for AB has to be two commands, one for port A and one for port B.

[corneliusmunz]

Hi @alwayslinux2 ! Thanks very much for your pull request. I will check it hopefully today. The request seems reasonable. Maybe i have some comments regarding the boost related functions and the naming but i will directly reply with comments in the code. Unfortunately i have no control+ hub at the moment to test it with a real device but i will review your code

[GianCann]

There is some news about this?

[marcrupprath]

Hallo, the Technic Hub is still supported, because it use the same protocoll ;-)
Tested 4 Ports of "myBoostHub", works fine.

[marcrupprath]

Another question:
Do we realy need more than the base class ?
Because all of them uses same feature set, as discribed in LEGO wireless protocol ?!

At least i would like to have al changes implemented in base class first.
The availability of features depends more on connected devices, not on the hub (as i know so far).

[corneliusmunz]

@marcrupprath: You are right. The base class (Lpf2Hub) with the generic functions will work for the control+ hubs but the BoostHub class which inherits from the Lpf2Hub adds some basic movements specific for the Boost models (movements, turns, ...) and that movements use the combined AB port which is not existent in the control+ hubs. I think about the PR to have the base motor functions in the base class and only the movements without the combined port in the BoostHub class

[corneliusmunz]

@alwayslinux2 Hi Jeremy! Sorry for the late review of your PR. I struggle a littlebit with your additions/changes because i think i should refactor the lib in a way that the basic motor commands are in a base class which inherits from lpf2hub and can then be used by the boosthub and controlPlus hub controllers. In your supposed changes many of the code parts are copied and only the parts which uses the combined Port assignments AB or some default assignments to Port AB are really changed. So i will close the PR and do the refactoring like described above. I will mention your input as a contribution to that changes because i like your contribution which brings the library forward and gives support to additional hubs

[marcrupprath]

Hello Cornelius and Jeremy.
That is what i am talking about: Jeremy has implmented all those things, that i have tested with bosthub class with technic hub.

It works , ecept you have to be a little build carefull about powerup/powerdown ramps.
It seems that not all combinations worl properly:
Example with L Motor on technic hub: Runtime 20 sec, works fine if Ramping time is not above 1 sec.

Technic Hubs supports:

• Speedramps
• Positioning to Angle (as shown in Rally car steering , too)
• Running for specific time.

[corneliusmunz]

will close the PR. Support for ControlPlus (Technic) hub is available since release 0.7.0